Bug 164911 - [GTK] UI process crash in WebKit::WaylandCompositor::Surface::prepareTextureForPainting
Summary: [GTK] UI process crash in WebKit::WaylandCompositor::Surface::prepareTextureF...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-18 04:10 PST by Michael Catanzaro
Modified: 2016-12-19 13:31 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2016-11-30 03:48 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-11-18 04:10:48 PST 
UI process crash in WebKit::WaylandCompositor::Surface::prepareTextureForPainting. I have 39 reports of this:

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 WebKit::WaylandCompositor::Buffer::size at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp:140
 #1 WebKit::WaylandCompositor::Surface::prepareTextureForPainting at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp:217
 #2 WebKit::WaylandCompositor::getTexture at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp:490
 #3 WebKit::AcceleratedBackingStoreWayland::paint at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:93
 #4 webkitWebViewBaseDraw at /usr/src/debug/webkitgtk-2.14.1/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:539
 #5 gtk_widget_draw_internal at gtkwidget.c:7015
 #6 gtk_container_propagate_draw at gtkcontainer.c:3838
 #7 gtk_container_draw at gtkcontainer.c:3658
 #8 gtk_widget_draw_internal at gtkwidget.c:7015
 #9 gtk_container_propagate_draw at gtkcontainer.c:3838

|this| is null in WebKit::WaylandCompositor::Buffer::size. Full backtrace downstream.
Comment 1 Carlos Garcia Campos 2016-11-30 03:48:07 PST 
Created attachment 295713 [details]
Patch
Comment 2 Michael Catanzaro 2016-11-30 09:37:16 PST 
Comment on attachment 295713 [details]
Patch

Look, it's not spam. :)
Comment 3 Carlos Garcia Campos 2016-11-30 09:51:54 PST 
(In reply to comment #2)
> Comment on attachment 295713 [details]
> Patch
> 
> Look, it's not spam. :)

I'm not sure, I couldn't reproduce it . . . :-D
Comment 4 Carlos Garcia Campos 2016-11-30 23:52:22 PST 
Committed r209177: <http://trac.webkit.org/changeset/209177>
Comment 5 Michael Catanzaro 2016-12-01 05:48:44 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 295713 [details]
> > Patch
> > 
> > Look, it's not spam. :)
> 
> I'm not sure, I couldn't reproduce it . . . :-D

I just hit this crash two minutes ago. It's really not spam!