Bug 164901

Summary: [WebIDL] Add support for ByteString
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Sam Weinig
Reported 2016-11-17 17:27:54 PST
[WebIDL] Add support for ByteString
Attachments
Patch (13.30 KB, patch)
2016-11-17 17:32 PST, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2016-11-17 17:32:30 PST
Created attachment 295114 [details] Patch
Darin Adler
Comment 2 2016-11-17 20:12:48 PST
Comment on attachment 295114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295114&action=review > Source/WebCore/bindings/js/JSDOMConvert.h:734 > + if (configuration == StringConversionConfiguration::TreatNullAsEmptyString) { > + if (value.isNull()) Maybe && instead of nested if statements? > Source/WebCore/bindings/js/JSDOMConvert.h:743 > + static constexpr bool needsState = true; > + static constexpr bool needsGlobalObject = false; Does a constexpr really need to also be marked static? > Source/WebCore/bindings/scripts/CodeGenerator.pm:70 > "DOMString" => 1, > + "ByteString" => 1, > "USVString" => 1, Alphabetical instead?
Sam Weinig
Comment 3 2016-11-17 21:07:29 PST
Committed r208876: <http://trac.webkit.org/changeset/208876>
Note You need to log in before you can comment on or make changes to this bug.