Bug 164859

Summary:

[JSC] Drop arguments.caller

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

JavaScriptCore

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, keith_miller, mark.lam, msaboff, rniwa, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=170536

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Patch	saam: review+

Yusuke Suzuki

Reported 2016-11-17 01:17:02 PST

https://github.com/tc39/ecma262/pull/689 ES2017 drops `arguments.caller`. Chrome 56 dropped it. Now it is included in kangax compat table.

Attachments
Patch (4.11 KB, patch) 2016-11-17 01:52 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (957.86 KB, application/zip) 2016-11-17 03:42 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (956.08 KB, application/zip) 2016-11-17 03:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.73 MB, application/zip) 2016-11-17 03:56 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (12.50 MB, application/zip) 2016-11-17 04:13 PST, Build Bot	no flags	Details
Patch (11.67 KB, patch) 2016-11-17 15:39 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.06 MB, application/zip) 2016-11-17 16:24 PST, Build Bot	no flags	Details
Patch (17.00 KB, patch) 2016-11-17 16:27 PST, Yusuke Suzuki	saam: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2016-11-17 01:51:23 PST

It's not Function#caller. Arguments#caller.

Yusuke Suzuki

Comment 2 2016-11-17 01:52:08 PST

Created attachment 295042 [details] Patch WIP

Build Bot

Comment 3 2016-11-17 03:42:01 PST

Comment on attachment 295042 [details] Patch Attachment 295042 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2531122 New failing tests: js/strict-throw-type-error.html js/basic-strict-mode.html js/throw-type-error-is-unique.html

Build Bot

Comment 4 2016-11-17 03:42:05 PST

Created attachment 295044 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 5 2016-11-17 03:45:53 PST

Comment on attachment 295042 [details] Patch Attachment 295042 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2531127 New failing tests: js/strict-throw-type-error.html js/basic-strict-mode.html js/throw-type-error-is-unique.html

Build Bot

Comment 6 2016-11-17 03:45:57 PST

Created attachment 295045 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 7 2016-11-17 03:56:54 PST

Comment on attachment 295042 [details] Patch Attachment 295042 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2531153 New failing tests: js/strict-throw-type-error.html js/basic-strict-mode.html js/throw-type-error-is-unique.html

Build Bot

Comment 8 2016-11-17 03:56:58 PST

Created attachment 295046 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 9 2016-11-17 04:13:54 PST

Comment on attachment 295042 [details] Patch Attachment 295042 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2531190 New failing tests: js/strict-throw-type-error.html js/basic-strict-mode.html js/throw-type-error-is-unique.html

Build Bot

Comment 10 2016-11-17 04:13:58 PST

Created attachment 295047 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Yusuke Suzuki

Comment 11 2016-11-17 15:39:51 PST

Created attachment 295095 [details] Patch

Build Bot

Comment 12 2016-11-17 16:24:02 PST

Comment on attachment 295095 [details] Patch Attachment 295095 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2533865 New failing tests: js/strict-throw-type-error.html js/basic-strict-mode.html

Build Bot

Comment 13 2016-11-17 16:24:05 PST

Created attachment 295105 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Yusuke Suzuki

Comment 14 2016-11-17 16:27:37 PST

Created attachment 295107 [details] Patch

Saam Barati

Comment 15 2016-11-17 16:29:37 PST

Comment on attachment 295107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295107&action=review > LayoutTests/js/basic-strict-mode-expected.txt:188 > +FAIL (function f(arg){'use strict'; return Object.getOwnPropertyDescriptor(arguments, 'caller').value; })() should be undefined. Threw exception TypeError: undefined is not an object (evaluating 'Object.getOwnPropertyDescriptor(arguments, 'caller').value') > +FAIL (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(arguments, 'caller'); return descriptor.get === descriptor.set; })() should be true. Threw exception TypeError: undefined is not an object (evaluating 'descriptor.get') Can you fix this?

Yusuke Suzuki

Comment 16 2016-11-17 16:33:36 PST

Comment on attachment 295107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295107&action=review >> LayoutTests/js/basic-strict-mode-expected.txt:188 >> +FAIL (function f(arg){'use strict'; var descriptor = Object.getOwnPropertyDescriptor(arguments, 'caller'); return descriptor.get === descriptor.set; })() should be true. Threw exception TypeError: undefined is not an object (evaluating 'descriptor.get') > > Can you fix this? Oops! I missed it. Fixed.

Yusuke Suzuki

Comment 17 2016-11-17 16:37:38 PST

Committed r208867: <http://trac.webkit.org/changeset/208867>

Note You need to log in before you can comment on or make changes to this bug.