Bug 164852

Summary: REGRESSION(r208082): 1% Speedometer regression on iOS
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Ryosuke Niwa
Reported 2016-11-16 19:18:48 PST
Temporarily disable CEReactions entirely to recover this regression.
Attachments
Patch (8.12 KB, patch)
2016-11-16 19:28 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.40 KB, patch)
2016-11-16 19:57 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-11-16 19:28:39 PST
Created attachment 295018 [details] Patch
Chris Dumez
Comment 2 2016-11-16 19:37:16 PST
Comment on attachment 295018 [details] Patch I don't mind this but wouldn't be be simpler/better to comment out support for [CEReactions] in the bindings generator?
Ryosuke Niwa
Comment 3 2016-11-16 19:45:15 PST
(In reply to comment #2) > Comment on attachment 295018 [details] > Patch > > I don't mind this but wouldn't be be simpler/better to comment out support > for [CEReactions] in the bindings generator? There are CustomElementReactionStack allocated in custom binding code as well. Also, the release assertions still need to be removed because of the backup queue.
Ryosuke Niwa
Comment 4 2016-11-16 19:57:28 PST
Created attachment 295020 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-11-16 20:32:55 PST
Comment on attachment 295020 [details] Patch for landing Clearing flags on attachment: 295020 Committed r208837: <http://trac.webkit.org/changeset/208837>
WebKit Commit Bot
Comment 6 2016-11-16 20:33:00 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 7 2016-11-18 20:25:48 PST
Reverted r208837 for reason: The bots did not show a progression Committed r208917: <http://trac.webkit.org/changeset/208917>
Note You need to log in before you can comment on or make changes to this bug.