Bug 164851

Summary: Add an experimental API to find elements across shadow boundaries
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, jberlin, keith_miller, koivisto, kondapallykalyan, mark.lam, msaboff, saam, sam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the feature
none
Fixed build
none
Dropped the prefix none

Ryosuke Niwa
Reported 2016-11-16 19:16:21 PST
Add an experimental API to find elements that match a given selector across shadow boundaries.
Attachments
Adds the feature (32.24 KB, patch)
2016-11-16 19:49 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed build (33.43 KB, patch)
2016-11-16 21:37 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Dropped the prefix (42.26 KB, patch)
2016-11-17 20:15 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-11-16 19:17:11 PST
<rdar://problem/28220092>
Ryosuke Niwa
Comment 2 2016-11-16 19:49:15 PST
Created attachment 295019 [details] Adds the feature
Ryosuke Niwa
Comment 3 2016-11-16 21:37:37 PST
Created attachment 295025 [details] Fixed build
Sam Weinig
Comment 4 2016-11-16 23:02:34 PST
Comment on attachment 295025 [details] Fixed build View in context: https://bugs.webkit.org/attachment.cgi?id=295025&action=review > Source/WebCore/ChangeLog:9 > + Add window.webkitCollectMatchingElementsAcrossShadowBoundaries(Node node, DOMString selectors) What's the argument for prefixing this?
Ryosuke Niwa
Comment 5 2016-11-16 23:06:46 PST
(In reply to comment #4) > Comment on attachment 295025 [details] > Fixed build > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295025&action=review > > > Source/WebCore/ChangeLog:9 > > + Add window.webkitCollectMatchingElementsAcrossShadowBoundaries(Node node, DOMString selectors) > > What's the argument for prefixing this? I think the argument is that this is a proprietary API we don't intend to standardize.
Ryosuke Niwa
Comment 6 2016-11-17 20:15:14 PST
Created attachment 295131 [details] Dropped the prefix
Ryosuke Niwa
Comment 7 2016-11-17 21:05:08 PST
Comment on attachment 295131 [details] Dropped the prefix Thanks for the review!
WebKit Commit Bot
Comment 8 2016-11-17 21:30:31 PST
Comment on attachment 295131 [details] Dropped the prefix Clearing flags on attachment: 295131 Committed r208878: <http://trac.webkit.org/changeset/208878>
WebKit Commit Bot
Comment 9 2016-11-17 21:30:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.