Bug 164782

Summary: [WebGL] Remove unused Chromium-specific OpenGL extensions
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, graouts, gyuyoung.kim, jonlee, kondapallykalyan, noam, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+
Patch for committing
commit-queue: commit-queue-
Patch for committing none

Myles C. Maxfield
Reported 2016-11-15 11:29:28 PST
[WebGL] Remove unused Chromium-specific OpenGL extensions
Attachments
Patch (31.68 KB, patch)
2016-11-15 11:30 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (31.60 KB, patch)
2016-11-15 11:33 PST, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Patch for committing (31.68 KB, patch)
2016-11-15 11:56 PST, Myles C. Maxfield 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (31.68 KB, patch)
2016-11-15 12:07 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-11-15 11:30:09 PST
Created attachment 294856 [details] Patch
Myles C. Maxfield
Comment 2 2016-11-15 11:33:39 PST
Created attachment 294859 [details] Patch
Dean Jackson
Comment 3 2016-11-15 11:39:58 PST
Comment on attachment 294856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294856&action=review > Source/WebCore/html/canvas/WebGLDrawBuffers.cpp:107 > + bool supportsDepth = (context->getExtensions()->supports("GL_OES_depth_texture") We don't really need the outer () here. > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1373 > + zero = std::make_unique<unsigned char[]>(size); I wonder if we should change this to use JSC::Uint8Array::create? Aren't they zero filled anyway? > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1809 > + // Ensure we have a valid rendering state Nit: . > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1874 > + // Ensure we have a valid rendering state Nit: .
Myles C. Maxfield
Comment 4 2016-11-15 11:52:22 PST
Comment on attachment 294856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294856&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1373 >> + zero = std::make_unique<unsigned char[]>(size); > > I wonder if we should change this to use JSC::Uint8Array::create? Aren't they zero filled anyway? Why Uint8Array? It's just a temporary buffer that goes away immediately; if anything, it should be a Vector<uint8_t>.
Myles C. Maxfield
Comment 5 2016-11-15 11:56:26 PST
Created attachment 294861 [details] Patch for committing
WebKit Commit Bot
Comment 6 2016-11-15 11:58:30 PST
Comment on attachment 294861 [details] Patch for committing Rejecting attachment 294861 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 294861, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2521215
Myles C. Maxfield
Comment 7 2016-11-15 12:07:52 PST
Created attachment 294862 [details] Patch for committing
Myles C. Maxfield
Comment 8 2016-11-15 12:55:35 PST
Committed r208747: <http://trac.webkit.org/changeset/208747>
Note You need to log in before you can comment on or make changes to this bug.