Bug 164765

Summary: [iOS WK2] Implement support for visual viewports
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, dino, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, simon.fraser, thorton, tonikitoo, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164260    
Attachments:
Description Flags
Patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2016-11-14 21:17:01 PST
[iOS WK2] Implement support for visual viewports
Attachments
Patch (46.98 KB, patch)
2016-11-14 21:40 PST, Simon Fraser (smfr) 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.18 MB, application/zip)
2016-11-14 23:18 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-11-14 21:40:19 PST
Created attachment 294809 [details] Patch
Build Bot
Comment 2 2016-11-14 23:18:28 PST
Comment on attachment 294809 [details] Patch Attachment 294809 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2518107 New failing tests: fast/visual-viewport/rtl-zoomed-rects.html fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html fast/visual-viewport/zoomed-rects.html fast/visual-viewport/zoomed-fixed.html
Build Bot
Comment 3 2016-11-14 23:18:32 PST
Created attachment 294820 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Tim Horton
Comment 4 2016-11-15 10:15:55 PST
Comment on attachment 294809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294809&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1277 > + BOOL needUpdateVisbleContentRects = _page->updateLayoutViewportParameters(layerTreeTransaction); VISBLE > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:222 > +// FIXME: rename this when visual viewports are the default. What's up with all the leading lowercase letters in your comments?
Simon Fraser (smfr)
Comment 5 2016-11-15 14:45:45 PST
https://trac.webkit.org/changeset/208748
Note You need to log in before you can comment on or make changes to this bug.