Bug 164763
| Summary: | [WebCore] Drop frame protection for script execution | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cdumez, fred.wang, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Yusuke Suzuki
In ScriptController and ScriptElement, there are some `Ref<Frame> protector(frame)` protections.
It avoids destroying Frame during executing scripts.
But if there are no code touching Frame after the execution of the script, we do not need to save Frame.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
Not in ScriptElement.
Michael Catanzaro
Be careful if changing this: the ScriptController is actually owned by its Frame, so removing protectors could cause the ScriptController itself to be destroyed.