Bug 164750

Summary: CodeCache should stop pretending to cache builtins
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Geoffrey Garen
Reported 2016-11-14 17:08:44 PST
CodeCache should stop pretending to cache builtins
Attachments
Patch (15.15 KB, patch)
2016-11-14 17:13 PST, Geoffrey Garen 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-11-14 17:13:04 PST
Created attachment 294778 [details] Patch
Saam Barati
Comment 2 2016-11-14 17:20:35 PST
Comment on attachment 294778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294778&action=review r=me > Source/JavaScriptCore/parser/SourceCodeKey.h:-48 > - (static_cast<unsigned>(builtinMode) << 1) | Maybe it's worth updating the other shifts to be subtracted by 1?
Geoffrey Garen
Comment 3 2016-11-15 11:04:25 PST
Committed r208736: <http://trac.webkit.org/changeset/208736>
Note You need to log in before you can comment on or make changes to this bug.