Summary: | Update SubtleCrypto::unwrapKey to match the latest spec | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, esprehn+autocc, jiewen_tan, kondapallykalyan, rob, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 160883 | ||||||||
Attachments: |
|
Description
Jiewen Tan
2016-11-14 16:01:18 PST
Created attachment 295801 [details]
Patch
Attachment 295801 [details] did not pass style-queue:
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:170: CryptoAlgorithmAES_KW::unwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:41: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:52: unwrapKeyAES_KW is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:78: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 4 in 33 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 295875 [details]
Patch
Attachment 295875 [details] did not pass style-queue:
ERROR: Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.cpp:170: CryptoAlgorithmAES_KW::unwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:41: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:52: unwrapKeyAES_KW is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/crypto/mac/CryptoAlgorithmAES_KWMac.cpp:78: CryptoAlgorithmAES_KW::platformUnwrapKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 4 in 33 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 295875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295875&action=review Looks good! > Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:940 > + // The following operation should be performed asynchronously. Is this a note to remind you to do something in the future? Comment on attachment 295875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295875&action=review Thanks Brent for r+ my patch. >> Source/WebCore/bindings/js/JSSubtleCryptoCustom.cpp:940 >> + // The following operation should be performed asynchronously. > > Is this a note to remind you to do something in the future? Not really. It is a note to remind me of whether the following operation will be executed asynchronously/synchronously. Comment on attachment 295875 [details] Patch Clearing flags on attachment: 295875 Committed r209200: <http://trac.webkit.org/changeset/209200> All reviewed patches have been landed. Closing bug. |