Bug 164735

Summary: Expected: add missing `inline`
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Web Template FrameworkAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, jfbastien, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

JF Bastien
Reported 2016-11-14 15:28:30 PST
Free functions and full template specializations need to be `static inline`, or in a .cpp file, otherwise each .o creates a duplicate symbol which makes the linker very sad.
Attachments
patch (2.41 KB, patch)
2016-11-14 15:32 PST, JF Bastien 		no flags
DetailsFormatted DiffDiff
patch (2.40 KB, patch)
2016-11-14 15:37 PST, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2016-11-14 15:32:13 PST
Created attachment 294759 [details] patch
JF Bastien
Comment 2 2016-11-14 15:37:14 PST
Created attachment 294762 [details] patch Drop `static`, only `inline` is needed.
Yusuke Suzuki
Comment 3 2016-11-14 15:37:38 PST
Comment on attachment 294762 [details] patch r=me
WebKit Commit Bot
Comment 4 2016-11-14 16:13:32 PST
Comment on attachment 294762 [details] patch Clearing flags on attachment: 294762 Committed r208713: <http://trac.webkit.org/changeset/208713>
WebKit Commit Bot
Comment 5 2016-11-14 16:13:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.