Bug 164725

Summary:

[Mac][iOS][WK2] Tighten permissions to change CapsLock delay

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit2

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+, ap: commit-queue-

Brent Fulgham

Reported 2016-11-14 12:16:17 PST

Tighten up the conditions under which we can adjust the Caps Lock delay. We only need this in specific instances, so why allow it all the time?

Attachments
Patch (1.45 KB, patch) 2016-11-14 12:18 PST, Brent Fulgham	ap: review+ ap: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2016-11-14 12:16:44 PST

Brent Fulgham

Comment 2 2016-11-14 12:18:05 PST

Alexey Proskuryakov

Comment 3 2016-11-14 13:35:06 PST

Comment on attachment 294727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294727&action=review > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:319 > + (allow iokit-set-properties (iokit-property "CapsLockDelayOverrideâ))) This line has a smart quote.

Brent Fulgham

Comment 4 2016-11-14 13:47:36 PST

Comment on attachment 294727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294727&action=review >> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:319 >> + (allow iokit-set-properties (iokit-property "CapsLockDelayOverrideâ))) > > This line has a smart quote. Argh! Fixed.

Brent Fulgham

Comment 5 2016-11-14 13:47:47 PST

Note You need to log in before you can comment on or make changes to this bug.