| Summary: | Web Inspector: Settings tab should look more like a native macOS view | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 294694 [details]
Patch
Created attachment 294695 [details]
[Image] Before/After
Comment on attachment 294694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294694&action=review > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css:76 > + top: 0.5px; This works well on non-retina as well. Comment on attachment 294694 [details] Patch Clearing flags on attachment: 294694 Committed r208686: <http://trac.webkit.org/changeset/208686> All reviewed patches have been landed. Closing bug. |
Created attachment 294692 [details] [Image] Current Settings Tab and Safari Settings View on macOS Sierra General visual design fixes: 1. Vertically align text. 2. Make font size of text fields, number fields, and dropdown menus match the font size of its labels. macOS specific: 1. Use regular font-weight, not `font-weight: lighter`. 2. Increase spacing between section names and UI controls. 3. Make checkboxes larger. 4. Increase spacing between checkboxes and their label text. 5. Changed the background from white to light gray.