Bug 164708 - Web Inspector: Settings tab should look more like a native macOS view
Summary: Web Inspector: Settings tab should look more like a native macOS view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-13 20:58 PST by Nikita Vasilyev
Modified: 2016-11-14 09:43 PST (History)
7 users (show)

See Also:


Attachments
[Image] Current Settings Tab and Safari Settings View on macOS Sierra (93.98 KB, image/png)
2016-11-13 20:58 PST, Nikita Vasilyev
no flags Details
Patch (3.67 KB, patch)
2016-11-13 22:47 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] Before/After (157.83 KB, image/png)
2016-11-13 22:48 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-11-13 20:58:28 PST
Created attachment 294692 [details]
[Image] Current Settings Tab and Safari Settings View on macOS Sierra

General visual design fixes:
1. Vertically align text.
2. Make font size of text fields, number fields, and dropdown menus match the font size of its labels.

macOS specific:
1. Use regular font-weight, not `font-weight: lighter`.
2. Increase spacing between section names and UI controls.
3. Make checkboxes larger.
4. Increase spacing between checkboxes and their label text.
5. Changed the background from white to light gray.
Comment 1 Radar WebKit Bug Importer 2016-11-13 21:01:29 PST
<rdar://problem/29241296>
Comment 2 Nikita Vasilyev 2016-11-13 22:47:49 PST
Created attachment 294694 [details]
Patch
Comment 3 Nikita Vasilyev 2016-11-13 22:48:40 PST
Created attachment 294695 [details]
[Image] Before/After
Comment 4 Nikita Vasilyev 2016-11-13 22:53:31 PST
Comment on attachment 294694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294694&action=review

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css:76
> +    top: 0.5px;

This works well on non-retina as well.
Comment 5 WebKit Commit Bot 2016-11-14 09:43:50 PST
Comment on attachment 294694 [details]
Patch

Clearing flags on attachment: 294694

Committed r208686: <http://trac.webkit.org/changeset/208686>
Comment 6 WebKit Commit Bot 2016-11-14 09:43:54 PST
All reviewed patches have been landed.  Closing bug.