Bug 164695

Summary: Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, jfbastien, keith_miller, msaboff, ossy, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 155145, 164701    
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2016-11-12 19:43:31 PST
This gives us more flexibility when specific tests needs to enable special JSC options in order to exercise specific code paths. It also saves us from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest. We can now just use runFTLNoCJIT in its place.
Attachments
proposed patch. (15.35 KB, patch)
2016-11-12 19:52 PST, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-11-12 19:52:42 PST
Created attachment 294647 [details] proposed patch.
JF Bastien
Comment 2 2016-11-13 10:26:17 PST
Nice, lgtm!
Keith Miller
Comment 3 2016-11-14 10:26:47 PST
Comment on attachment 294647 [details] proposed patch. seems reasonable.
Mark Lam
Comment 4 2016-11-14 10:32:46 PST
Thanks for the review. Landed in r208692: <http://trac.webkit.org/r208692>.
Note You need to log in before you can comment on or make changes to this bug.