Summary: | Web Inspector: SourceCodeTextEditor should display execution lines for background threads | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-11-11 23:57:02 PST
I like including an inline message similar to our inline errors/warnings for execution lines. Would execution lines belonging to background threads be styled differently than the line associated with the active call frame? It might be nice to use opacity (or some other style) to de-emphasize execution lines for inactive call frames. What if two threads are paused at the same location in the same script? Maybe we could indicate something in the inline message, like having a disclosure triangle. (In reply to comment #2) > I like including an inline message similar to our inline errors/warnings for > execution lines. Would execution lines belonging to background threads be > styled differently than the line associated with the active call frame? It > might be nice to use opacity (or some other style) to de-emphasize execution > lines for inactive call frames. > > What if two threads are paused at the same location in the same script? > Maybe we could indicate something in the inline message, like having a > disclosure triangle. Currently threads are limited to whole worker scripts, so there is never a mix. In the future we might want to consider things that you mention. > > What if two threads are paused at the same location in the same script?
> > Maybe we could indicate something in the inline message, like having a
> > disclosure triangle.
>
> Currently threads are limited to whole worker scripts, so there is never a
> mix. In the future we might want to consider things that you mention.
This is possible right now. If two workers are spawned with the same script ("worker.js") then we should show both in the SourceCodeTextEditor for that script.
Created attachment 294774 [details]
[PATCH] Proposed Fix
Probably won't apply
Created attachment 294775 [details]
[IMAGE] Thread Line Indicator - Multiple Threads in the same Resource
Comment on attachment 294774 [details] [PATCH] Proposed Fix Attachment 294774 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2516778 New failing tests: js/regress-141098.html Created attachment 294788 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 294788 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
Failure appears unrelated.
Comment on attachment 294774 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=294774&action=review > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:714 > + } > + threads.push(target); Nit: newline between. > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:730 > + threads.remove(target); > + if (threads.length) { Nit: newline between. Comment on attachment 294774 [details] [PATCH] Proposed Fix Clearing flags on attachment: 294774 Committed r208783: <http://trac.webkit.org/changeset/208783> All reviewed patches have been landed. Closing bug. |