Bug 164632

Summary: [DOMJIT] DOMJIT accessor attribute in IDL should say like DOMJIT=Getter
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: BindingsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, esprehn+autocc, fpizlo, ggaren, kangil.han, kondapallykalyan, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Yusuke Suzuki
Reported 2016-11-10 21:52:51 PST
...
Attachments
Patch (10.54 KB, patch)
2016-11-10 22:28 PST, Yusuke Suzuki 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-11-10 22:28:10 PST
Created attachment 294474 [details] Patch
Sam Weinig
Comment 2 2016-11-10 22:58:25 PST
Comment on attachment 294474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294474&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1795 > + die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter"); This would read slightly better if it said "Only DOMJIT=Getter is supported for attributes". Also, I prefer using the assert() function rather than die, since it gives you a nice stack trace. > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3407 > + die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter"); Same.
Yusuke Suzuki
Comment 3 2016-11-10 23:30:59 PST
Comment on attachment 294474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294474&action=review Thanks! >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1795 >> + die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter"); > > This would read slightly better if it said "Only DOMJIT=Getter is supported for attributes". Also, I prefer using the assert() function rather than die, since it gives you a nice stack trace. Oh, nice! Use assert and the above phrase. >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3407 >> + die "Only DOMJIT=Getter is supported for attribute" unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter"); > > Same. Fixed.
Yusuke Suzuki
Comment 4 2016-11-10 23:45:14 PST
Committed r208582: <http://trac.webkit.org/changeset/208582>
Note You need to log in before you can comment on or make changes to this bug.