Bug 164625

Summary: Remove unused FontService from sandbox
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, ap, bfulgham
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Brent Fulgham
Reported 2016-11-10 17:17:23 PST
In macOS Sierra (and newer) we no longer need access to com.apple.FontServer. So, remove it from the sandbox.
Attachments
Patch (2.84 KB, patch)
2016-11-10 17:20 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (47.97 KB, patch)
2016-11-10 18:40 PST, Brent Fulgham 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-11-10 17:18:33 PST
<rdar://problem/26899976>
Brent Fulgham
Comment 2 2016-11-10 17:20:45 PST
Created attachment 294447 [details] Patch
Brent Fulgham
Comment 3 2016-11-10 18:40:23 PST
Created attachment 294457 [details] Patch
Brent Fulgham
Comment 4 2016-11-10 18:41:00 PST
Revised patch to generate from an 'in' file so we can exclude content more easily based on OS level. This will be useful in some future patches.
Alex Christensen
Comment 5 2016-11-11 09:10:43 PST
Comment on attachment 294457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294457&action=review > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:81 > +;; OS X 10.7 (Lion) compatibility Really? > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:248 > +(if (equal? os-version "10.7") Do we still need this? > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:355 > +(if (equal? os-version "10.7") ...
Brent Fulgham
Comment 6 2016-11-11 09:20:42 PST
(In reply to comment #5) > Comment on attachment 294457 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294457&action=review > > > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:81 > > +;; OS X 10.7 (Lion) compatibility > > Really? > > > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:248 > > +(if (equal? os-version "10.7") > > Do we still need this? > > > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:355 > > +(if (equal? os-version "10.7") > > ... Not to fear! More changes coming soon. This is just a move of the existing file to a new location -- I didn't want to clean it up yet.
Brent Fulgham
Comment 7 2016-11-11 09:21:58 PST
Committed r208589: <http://trac.webkit.org/changeset/208589>
Brent Fulgham
Comment 8 2016-11-28 17:17:28 PST
A follow-up fix was landed here: Committed r208835: <https://trac.webkit.org/changeset/208835>
Note You need to log in before you can comment on or make changes to this bug.