Bug 164625

Summary: Remove unused FontService from sandbox
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, ap, bfulgham
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Description Brent Fulgham 2016-11-10 17:17:23 PST 
In macOS Sierra (and newer) we no longer need access to com.apple.FontServer. So, remove it from the sandbox.
Comment 1 Brent Fulgham 2016-11-10 17:18:33 PST 
<rdar://problem/26899976>
Comment 2 Brent Fulgham 2016-11-10 17:20:45 PST 
Created attachment 294447 [details]
Patch
Comment 3 Brent Fulgham 2016-11-10 18:40:23 PST 
Created attachment 294457 [details]
Patch
Comment 4 Brent Fulgham 2016-11-10 18:41:00 PST 
Revised patch to generate from an 'in' file so we can exclude content more easily based on OS level. This will be useful in some future patches.
Comment 5 Alex Christensen 2016-11-11 09:10:43 PST 
Comment on attachment 294457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294457&action=review

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:81
> +;; OS X 10.7 (Lion) compatibility

Really?

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:248
> +(if (equal? os-version "10.7")

Do we still need this?

> Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:355
> +(if (equal? os-version "10.7")

...
Comment 6 Brent Fulgham 2016-11-11 09:20:42 PST 
(In reply to comment #5)
> Comment on attachment 294457 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294457&action=review
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:81
> > +;; OS X 10.7 (Lion) compatibility
> 
> Really?
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:248
> > +(if (equal? os-version "10.7")
> 
> Do we still need this?
> 
> > Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:355
> > +(if (equal? os-version "10.7")
> 
> ...

Not to fear! More changes coming soon. This is just a move of the existing file to a new location -- I didn't want to clean it up yet.
Comment 7 Brent Fulgham 2016-11-11 09:21:58 PST 
Committed r208589: <http://trac.webkit.org/changeset/208589>
Comment 8 Brent Fulgham 2016-11-28 17:17:28 PST 
A follow-up fix was landed here:

Committed r208835: <https://trac.webkit.org/changeset/208835>