Bug 164581

Summary: [JSC] op_in should have ArrayProfile
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Yusuke Suzuki
Reported 2016-11-09 23:35:29 PST
Much time is taken in Array.prototype.map in ES6SampleBench/Basic. And sampling profiler tells us that op_in is one of the hottest bytecode. We have a path optimizing `"string" in obj` case, but we always fall into the slow generic code for `index in array` case. We should have array profile and handle op_in like GetByVal thing.
Attachments
Patch (27.57 KB, patch)
2017-02-08 12:15 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.60 KB, patch)
2017-02-08 13:36 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-02-08 12:15:59 PST
Created attachment 300935 [details] Patch
Keith Miller
Comment 2 2017-02-08 13:36:41 PST
Created attachment 300954 [details] Patch for landing
WebKit Commit Bot
Comment 3 2017-02-08 16:03:53 PST
Comment on attachment 300954 [details] Patch for landing Clearing flags on attachment: 300954 Committed r211908: <http://trac.webkit.org/changeset/211908>
WebKit Commit Bot
Comment 4 2017-02-08 16:03:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.