Summary: | Clean up Storage code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2016-11-09 15:03:15 PST
Created attachment 294296 [details]
Patch
Comment on attachment 294296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294296&action=review > Source/WebKit2/ChangeLog:3 > + Clean up Storage code This patch doesn't appear to be exclusively related to doing... this. > Source/WebKit2/Platform/IPC/HandleMessage.h:3 > +/* > + * Copyright (C) 2016 Apple Inc. All rights reserved. > + * A long used .h file without a header! Wow! Please put in all the copyright dates where Apple has touched it. (assuming it's not new this year) > Source/WebKit2/Platform/IPC/HandleMessage.h:82 > void callMemberFunctionImpl(C* object, MF function, Connection& connection, ArgsTuple&& args, std::index_sequence<ArgsIndex...>) > { > - (object->*function)(connection, std::get<ArgsIndex>(args)...); > + (object->*function)(connection, std::get<ArgsIndex>(std::forward<ArgsTuple>(args))...); Apparently this is for a future patch. Please do it in the future patch. > Source/WebKit2/UIProcess/Storage/LocalStorageDatabase.h:26 > +#pragma once 👍 > Source/WebKit/Storage/StorageAreaImpl.h:26 > +#pragma once 👍 |