Bug 164554

Summary:

[Modern Media Controls] Media Controller: update controls based on fullscreen playback on macOS

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, graouts, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 10

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Patch	none

Antoine Quint

Reported 2016-11-09 11:50:45 PST

Now that we have the logic in place to enter fullscreen and to display fullscreen controls, we need to correctly toggle between fullscreen and inline controls on macOS.

Attachments
Patch (12.46 KB, patch) 2016-11-09 11:55 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.30 MB, application/zip) 2016-11-09 13:11 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (1.34 MB, application/zip) 2016-11-09 13:24 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.64 MB, application/zip) 2016-11-09 15:44 PST, Build Bot	no flags	Details
Patch (12.41 KB, patch) 2016-11-10 01:12 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.79 MB, application/zip) 2016-11-10 02:17 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-yosemite (1.13 MB, application/zip) 2016-11-10 02:18 PST, Build Bot	no flags	Details
Patch (12.40 KB, patch) 2016-11-10 02:25 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-11-09 11:53:48 PST

<rdar://problem/29183439>

Antoine Quint

Comment 2 2016-11-09 11:55:39 PST

Created attachment 294260 [details] Patch

Dean Jackson

Comment 3 2016-11-09 12:19:20 PST

Comment on attachment 294260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294260&action=review > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:44 > + let traits = window.navigator.platform === "MacIntel" ? LayoutTraits.macOS : LayoutTraits.iOS; uuugh.... is there any way we can do this better?

Build Bot

Comment 4 2016-11-09 13:11:17 PST

Comment on attachment 294260 [details] Patch Attachment 294260 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2484905 New failing tests: media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

Build Bot

Comment 5 2016-11-09 13:11:20 PST

Created attachment 294273 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-11-09 13:24:01 PST

Comment on attachment 294260 [details] Patch Attachment 294260 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2485013 New failing tests: media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

Build Bot

Comment 7 2016-11-09 13:24:04 PST

Created attachment 294274 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-11-09 15:44:38 PST

Comment on attachment 294260 [details] Patch Attachment 294260 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2485693 New failing tests: media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

Build Bot

Comment 9 2016-11-09 15:44:40 PST

Created attachment 294298 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antoine Quint

Comment 10 2016-11-10 01:12:18 PST

Created attachment 294344 [details] Patch

Build Bot

Comment 11 2016-11-10 02:17:14 PST

Comment on attachment 294344 [details] Patch Attachment 294344 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2488176 Number of test failures exceeded the failure limit.

Build Bot

Comment 12 2016-11-10 02:17:16 PST

Created attachment 294351 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 13 2016-11-10 02:18:08 PST

Comment on attachment 294344 [details] Patch Attachment 294344 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2488240 New failing tests: media/modern-media-controls/start-support/start-support-no-source.html media/modern-media-controls/volume-support/volume-support-media-api.html media/modern-media-controls/media-controller/media-controller-fullscreen-change.html media/modern-media-controls/volume-support/volume-support-media-api-mute.html media/modern-media-controls/playback-support/playback-support-autoplay.html http/tests/media/modern-media-controls/status-support/status-support-live-broadcast.html media/modern-media-controls/start-support/start-support-error.html media/modern-media-controls/start-support/start-support-click-to-start.html media/modern-media-controls/scrubber-support/scrubber-support-media-api.html media/modern-media-controls/remaining-time-support/remaining-time-support.html http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html media/modern-media-controls/mute-support/mute-support-muted.html media/modern-media-controls/start-support/start-support-autoplay.html media/modern-media-controls/start-support/start-support-audio.html media/modern-media-controls/start-support/start-support-fullscreen.html media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html media/modern-media-controls/status-support/status-support-error.html media/modern-media-controls/media-controller/media-controller-constructor.html media/modern-media-controls/mute-support/mute-support-media-api.html http/tests/media/modern-media-controls/status-support/status-support-loading.html media/modern-media-controls/mute-support/mute-support-button-click.html media/modern-media-controls/playback-support/playback-support-media-api.html media/modern-media-controls/fullscreen-support/fullscreen-support-click.html media/modern-media-controls/start-support/start-support-manual-play.html media/modern-media-controls/playback-support/playback-support-button-click.html media/modern-media-controls/elapsed-time-support/elapsed-time-support.html

Build Bot

Comment 14 2016-11-10 02:18:11 PST

Created attachment 294352 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antoine Quint

Comment 15 2016-11-10 02:25:25 PST

Created attachment 294353 [details] Patch

WebKit Commit Bot

Comment 16 2016-11-10 07:46:58 PST

Comment on attachment 294353 [details] Patch Clearing flags on attachment: 294353 Committed r208537: <http://trac.webkit.org/changeset/208537>

WebKit Commit Bot

Comment 17 2016-11-10 07:47:03 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.