Bug 164532

Summary: [WK2] Network cache speculative revalidation can cause loads to hang
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, commit-queue, koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-11-08 15:53:26 PST 
Network cache speculative revalidation can cause loads to hang when HTTP authentication is used.
Comment 1 Chris Dumez 2016-11-08 15:53:45 PST 
<rdar://problem/28519331>
Comment 2 Chris Dumez 2016-11-08 16:05:30 PST 
Created attachment 294199 [details]
Patch
Comment 3 Alex Christensen 2016-11-08 16:43:49 PST 
Comment on attachment 294199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294199&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:118
> +void SpeculativeLoad::canAuthenticateAgainstProtectionSpaceAsync(const WebCore::ProtectionSpace&)

#if USE(PROTECTION_SPACE_AUTH_CALLBACK) around this
Comment 4 Chris Dumez 2016-11-08 16:53:07 PST 
Created attachment 294201 [details]
Patch
Comment 5 Chris Dumez 2016-11-09 10:09:32 PST 
Comment on attachment 294201 [details]
Patch

Clearing flags on attachment: 294201

Committed r208437: <http://trac.webkit.org/changeset/208437>
Comment 6 Chris Dumez 2016-11-09 10:09:36 PST 
All reviewed patches have been landed.  Closing bug.