Bug 164495

Summary: Implement visual-viewport based position:fixed handling for Mac async scrolling
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, cmarcelo, commit-queue, dino, jamesr, luiz, rniwa, simon.fraser, thorton, tonikitoo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164260    
Attachments:
Description Flags
Patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2
none
Patch none

Simon Fraser (smfr)
Reported 2016-11-07 16:28:23 PST
Implement visual-viewport based position:fixed handling for Mac async scrolling
Attachments
Patch (89.49 KB, patch)
2016-11-07 16:44 PST, Simon Fraser (smfr) 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.60 MB, application/zip)
2016-11-07 17:43 PST, Build Bot 		no flags
Details
Patch (89.64 KB, patch)
2016-11-09 15:04 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-11-07 16:44:43 PST
Created attachment 294101 [details] Patch
Tim Horton
Comment 2 2016-11-07 17:05:32 PST
Comment on attachment 294101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294101&action=review > Source/WebCore/page/FrameView.cpp:1880 > + visibleContentRect.scale(1 / frameScaleFactor()); // Note thate frameScaleFactor() returns 1 for delegated scrolling (e.g. iOS WK2) thate! > Source/WebCore/page/FrameView.h:256 > + Yes, Yes is 0 and No is 1? > Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp:107 > + visibleContentSize.scale(1 / scale); // GROSS. So is the comment. > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:112 > + // FIXME: do we need to calculate a layoutViewport? Do we?
Build Bot
Comment 3 2016-11-07 17:43:34 PST
Comment on attachment 294101 [details] Patch Attachment 294101 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2470478 New failing tests: tiled-drawing/scrolling/fixed/remove-scrolling-role.html
Build Bot
Comment 4 2016-11-07 17:43:38 PST
Created attachment 294108 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Simon Fraser (smfr)
Comment 5 2016-11-09 15:04:47 PST
Created attachment 294297 [details] Patch
Simon Fraser (smfr)
Comment 6 2016-11-09 15:46:57 PST
https://trac.webkit.org/changeset/208503
Note You need to log in before you can comment on or make changes to this bug.