Bug 164484

Summary: preprocessor.pm: Use shellwords() instead of splitting preprocessor command by space
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cdumez, commit-queue, Hironori.Fujii, lforschler
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-11-07 09:46:48 PST
Now any quoted or escaped command line arguments can be passed in --preprocessor value independently of OS.
Attachments
Patch (2.08 KB, patch)
2016-11-07 09:49 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2016-11-07 10:41 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-11-07 09:48:37 PST
In particular, this is needed to compile with MinGW, because preprocessor.pm does not apply split() on Windows.
Konstantin Tokarev
Comment 2 2016-11-07 09:49:52 PST
Created attachment 294066 [details] Patch
Konstantin Tokarev
Comment 3 2016-11-07 10:41:08 PST
Created attachment 294069 [details] Patch
Konstantin Tokarev
Comment 4 2016-11-07 11:57:16 PST
MinGW works fine after r207412 without this patch, and it doesn't build in EWS
Konstantin Tokarev
Comment 5 2016-11-08 02:43:33 PST
It would be great if we used shellwords everywhere instead of splitting by space for parsing command line tokens, but not this time.
Note You need to log in before you can comment on or make changes to this bug.