Summary: | Web Automation: don't disable localStorage for ephemeral sessions that are being controlled by automation | ||
---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> |
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | andersca, bburg, beidson, darin, inspector-bugzilla-changes, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | All | ||
OS: | All |
Description
BJ Burg
2016-11-06 19:38:14 PST
Ephemeral sessions should *not* use the storage backend that actually stores to disk. So this bug is, by necessity, more than just "don't disable localStorage for ..." We'll need a mode for localStorage to use an in-memory backing store. (In reply to comment #2) > Ephemeral sessions should *not* use the storage backend that actually stores > to disk. > > So this bug is, by necessity, more than just "don't disable localStorage for > ..." > > We'll need a mode for localStorage to use an in-memory backing store. Does such a backing store already exist? It seems sketchy to me that the file-based backend is hooked up to ephemeral sessions right now, and we rely on this check to prevent code from actually using it. (In reply to comment #3) > (In reply to comment #2) > > Ephemeral sessions should *not* use the storage backend that actually stores > > to disk. > > > > So this bug is, by necessity, more than just "don't disable localStorage for > > ..." > > > > We'll need a mode for localStorage to use an in-memory backing store. > > Does such a backing store already exist? Yes - sessionStorage uses a per-WebView, in-memory backing store. And that's exactly what we'll want to use for localStorage in a WebView whose storage session is ephemeral. This bug is no longer needed. |