Summary: | Move Range from ExceptionCode to ExceptionOr | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||||||
Component: | Bindings | Assignee: | Darin Adler <darin> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, rniwa, sam, youennf | ||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||
Bug Blocks: | 164515, 164516 | ||||||||||||||||||||||
Attachments: |
|
Description
Darin Adler
2016-11-05 16:51:45 PDT
Created attachment 294016 [details]
Patch
Created attachment 294017 [details]
Patch
Created attachment 294025 [details]
Patch
Created attachment 294026 [details]
Patch
Created attachment 294124 [details]
Patch
Created attachment 294127 [details]
Patch
Created attachment 294134 [details]
Patch
Created attachment 294137 [details]
Patch
Created attachment 294139 [details]
Patch
Comment on attachment 294139 [details]
Patch
Patch passing on EWS and ready for review now.
Comment on attachment 294139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294139&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:1691 > + if (result.hasException()) > + return true; This check for exceptions wasn't there before. I guess we're becoming safer? > Source/WebCore/rendering/RenderNamedFlowThread.cpp:700 > + if (!intersectsResult.hasException() && intersectsResult.releaseReturnValue()) ditto Comment on attachment 294139 [details] Patch Clearing flags on attachment: 294139 Committed r208479: <http://trac.webkit.org/changeset/208479> All reviewed patches have been landed. Closing bug. |