Bug 164457

Summary: Move Range from ExceptionCode to ExceptionOr
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 164515, 164516    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Darin Adler 2016-11-05 16:51:45 PDT 
Move Range from ExceptionCode to ExceptionOr
Comment 1 Darin Adler 2016-11-05 22:36:29 PDT 
Created attachment 294016 [details]
Patch
Comment 2 Darin Adler 2016-11-05 22:53:30 PDT 
Created attachment 294017 [details]
Patch
Comment 3 Darin Adler 2016-11-06 10:15:44 PST 
Created attachment 294025 [details]
Patch
Comment 4 Darin Adler 2016-11-06 10:35:08 PST 
Created attachment 294026 [details]
Patch
Comment 5 Darin Adler 2016-11-07 19:39:04 PST 
Created attachment 294124 [details]
Patch
Comment 6 Darin Adler 2016-11-07 19:57:47 PST 
Created attachment 294127 [details]
Patch
Comment 7 Darin Adler 2016-11-07 21:52:15 PST 
Created attachment 294134 [details]
Patch
Comment 8 Darin Adler 2016-11-07 22:57:53 PST 
Created attachment 294137 [details]
Patch
Comment 9 Darin Adler 2016-11-07 23:34:45 PST 
Created attachment 294139 [details]
Patch
Comment 10 Darin Adler 2016-11-07 23:54:02 PST 
Comment on attachment 294139 [details]
Patch

Patch passing on EWS and ready for review now.
Comment 11 Alex Christensen 2016-11-08 10:11:04 PST 
Comment on attachment 294139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294139&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1691
> +    if (result.hasException())
> +        return true;

This check for exceptions wasn't there before.  I guess we're becoming safer?

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:700
> +                        if (!intersectsResult.hasException() && intersectsResult.releaseReturnValue())

ditto
Comment 12 WebKit Commit Bot 2016-11-09 13:31:01 PST 
Comment on attachment 294139 [details]
Patch

Clearing flags on attachment: 294139

Committed r208479: <http://trac.webkit.org/changeset/208479>
Comment 13 WebKit Commit Bot 2016-11-09 13:31:07 PST 
All reviewed patches have been landed.  Closing bug.