Bug 164444

Summary:

testWASM should be very sad if no options are provided

Product:

WebKit

Reporter:

JF Bastien <jfbastien>

Component:

JavaScriptCore

Assignee:

JF Bastien <jfbastien>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159775

Attachments:

Description	Flags
patch	saam: review+, saam: commit-queue-
patch	none

Description JF Bastien 2016-11-04 18:42:10 PDT

Because I've been running it wrong all along.

Comment 1 JF Bastien 2016-11-04 18:43:43 PDT

Created attachment 293967 [details]
patch

Comment 2 Saam Barati 2016-11-04 18:47:38 PDT

Comment on attachment 293967 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293967&action=review

> Source/JavaScriptCore/testWasm.cpp:78
> +            continue;

Should be RELEASE_ASSERT_NOT_REACHED() IMO

Comment 3 JF Bastien 2016-11-04 18:51:50 PDT

Created attachment 293969 [details]
patch

Address comment.

Comment 4 WebKit Commit Bot 2016-11-04 19:51:16 PDT

Comment on attachment 293969 [details]
patch

Clearing flags on attachment: 293969

Committed r208413: <http://trac.webkit.org/changeset/208413>

Comment 5 WebKit Commit Bot 2016-11-04 19:51:19 PDT

All reviewed patches have been landed.  Closing bug.