Bug 164444

Summary: testWASM should be very sad if no options are provided
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159775    
Attachments:
Description Flags
patch
saam: review+, saam: commit-queue-
patch none

JF Bastien
Reported 2016-11-04 18:42:10 PDT
Because I've been running it wrong all along.
Attachments
patch (2.39 KB, patch)
2016-11-04 18:43 PDT, JF Bastien 		saam: review+
saam: commit-queue-
DetailsFormatted DiffDiff
patch (2.40 KB, patch)
2016-11-04 18:51 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2016-11-04 18:43:43 PDT
Created attachment 293967 [details] patch
Saam Barati
Comment 2 2016-11-04 18:47:38 PDT
Comment on attachment 293967 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=293967&action=review > Source/JavaScriptCore/testWasm.cpp:78 > + continue; Should be RELEASE_ASSERT_NOT_REACHED() IMO
JF Bastien
Comment 3 2016-11-04 18:51:50 PDT
Created attachment 293969 [details] patch Address comment.
WebKit Commit Bot
Comment 4 2016-11-04 19:51:16 PDT
Comment on attachment 293969 [details] patch Clearing flags on attachment: 293969 Committed r208413: <http://trac.webkit.org/changeset/208413>
WebKit Commit Bot
Comment 5 2016-11-04 19:51:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.