| Summary: | IndexedDB 2.0: Clean up more transaction abort and exception throwing behavior from IDBObjectStore | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 160306 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Brady Eidson
2016-11-04 13:13:03 PDT
This patch will actually shift a few PASSes to FAILs in the w3c tests, but those are problems in the spec that are under discussion, and not actually meaningful regressions. Created attachment 293935 [details]
Patch
Forgot some changes, ignore that patch Created attachment 293938 [details]
Patch
Comment on attachment 293938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293938&action=review > LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor_advance_index7-expected.txt:2 > -PASS IDBCursor.advance() - index - throw TransactionInactiveError > +FAIL IDBCursor.advance() - index - throw TransactionInactiveError assert_throws: Calling advance() should throws an exception TransactionInactiveError when the transaction is not active. function "function () { :( > LayoutTests/imported/w3c/web-platform-tests/IndexedDB/idbcursor_continue_index7-expected.txt:2 > -PASS IDBCursor.continue() - index - throw TransactionInactiveError > +FAIL IDBCursor.continue() - index - throw TransactionInactiveError assert_throws: Calling continue() should throws an exception TransactionInactiveError when the transaction is not active. function "function () { :( Comment on attachment 293938 [details] Patch Rejecting attachment 293938 [details] from commit-queue. New failing tests: imported/w3c/IndexedDB-private-browsing/idbindex_getKey7.html imported/w3c/IndexedDB-private-browsing/idbcursor_continue_index7.html imported/w3c/IndexedDB-private-browsing/idbindex_openCursor2.html imported/w3c/IndexedDB-private-browsing/idbcursor_advance_index7.html imported/w3c/IndexedDB-private-browsing/idbindex_get7.html imported/w3c/IndexedDB-private-browsing/idbindex_openKeyCursor3.html Full output: http://webkit-queues.webkit.org/results/2463924 Created attachment 293950 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 293938 [details] Patch Attachment 293938 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2463913 New failing tests: imported/w3c/IndexedDB-private-browsing/idbindex_getKey7.html imported/w3c/IndexedDB-private-browsing/idbcursor_continue_index7.html imported/w3c/IndexedDB-private-browsing/idbindex_openCursor2.html imported/w3c/IndexedDB-private-browsing/idbcursor_advance_index7.html imported/w3c/IndexedDB-private-browsing/idbindex_get7.html imported/w3c/IndexedDB-private-browsing/idbindex_openKeyCursor3.html Created attachment 293951 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 293938 [details] Patch Attachment 293938 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2463939 New failing tests: imported/w3c/IndexedDB-private-browsing/idbindex_getKey7.html imported/w3c/IndexedDB-private-browsing/idbcursor_continue_index7.html imported/w3c/IndexedDB-private-browsing/idbindex_openCursor2.html imported/w3c/IndexedDB-private-browsing/idbcursor_advance_index7.html imported/w3c/IndexedDB-private-browsing/idbindex_get7.html imported/w3c/IndexedDB-private-browsing/idbindex_openKeyCursor3.html Created attachment 293955 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Whoops, forgot to update the private tests copy. Landing manually with those: https://trac.webkit.org/changeset/208405 |