Bug 164413

Summary: [Readable Streams API] Implement ReadableByteStreamController close()
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, commit-queue, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Romain Bellessort
Reported 2016-11-04 06:37:43 PDT
Implement close() method of ReadableByteStreamController
Attachments
Patch (11.26 KB, patch)
2016-11-04 06:55 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2016-11-16 01:21 PST, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-11-04 06:55:44 PDT
Created attachment 293884 [details] Patch
WebKit Commit Bot
Comment 2 2016-11-07 12:38:37 PST
Comment on attachment 293884 [details] Patch Rejecting attachment 293884 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 293884, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ed.txt Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/streams/readable-byte-stream-controller-expected.txt.rej patching file LayoutTests/streams/readable-byte-stream-controller.js Hunk #1 FAILED at 61. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/streams/readable-byte-stream-controller.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2468790
Romain Bellessort
Comment 3 2016-11-16 01:21:13 PST
Created attachment 294927 [details] Patch
Romain Bellessort
Comment 4 2016-11-16 05:33:43 PST
Comment on attachment 294927 [details] Patch Commit failed due to another patch that had been rolled out. The "new" version is simply a rebase.
WebKit Commit Bot
Comment 5 2016-11-16 06:00:42 PST
Comment on attachment 294927 [details] Patch Clearing flags on attachment: 294927 Committed r208790: <http://trac.webkit.org/changeset/208790>
WebKit Commit Bot
Comment 6 2016-11-16 06:00:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.