Bug 164384

Summary: Add new 'other' Apple Pay button style
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Anders Carlsson
Reported 2016-11-03 16:14:49 PDT
Add new 'other' Apple Pay button style
Attachments
Patch (8.09 KB, patch)
2016-11-03 16:17 PDT, Anders Carlsson 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-11-03 16:17:51 PDT
Created attachment 293820 [details] Patch
Dean Jackson
Comment 2 2016-11-03 17:05:11 PDT
Comment on attachment 293820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293820&action=review > Source/WebCore/css/parser/CSSParser.cpp:1042 > + case CSSPropertyApplePayButtonType: // plain | buy | set-up | other > + if (valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp || valueID == CSSValueOther) This reminds me: you need code in CSSPropertyParser too (the new CSS parser)
Anders Carlsson
Comment 3 2016-11-04 10:44:05 PDT
Comment on attachment 293820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293820&action=review >> Source/WebCore/css/parser/CSSParser.cpp:1042 >> + if (valueID == CSSValuePlain || valueID == CSSValueBuy || valueID == CSSValueSetUp || valueID == CSSValueOther) > > This reminds me: you need code in CSSPropertyParser too (the new CSS parser) I think that's CSSParserFastPaths.cpp.
Anders Carlsson
Comment 4 2016-11-04 12:19:32 PDT
Committed r208392: <http://trac.webkit.org/changeset/208392>
Note You need to log in before you can comment on or make changes to this bug.