Bug 164373

Summary:

Use #pragma once in WebCore

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, joepeck

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	darin: review+
[PATCH] For Bots	none
[PATCH] For Landing	none

Joseph Pecoraro

Reported 2016-11-03 12:21:39 PDT

Use #pragma once more in WebCore. This gets a bunch of other top level directories.

Attachments
[PATCH] Proposed Fix (267.55 KB, patch) 2016-11-03 12:27 PDT, Joseph Pecoraro	darin: review+	Details Formatted Diff Diff
[PATCH] For Bots (265.16 KB, patch) 2016-11-11 23:31 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] For Landing (275.32 KB, patch) 2016-11-12 00:22 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-11-03 12:27:59 PDT

Created attachment 293788 [details] [PATCH] Proposed Fix Lets see what the bots say.

WebKit Commit Bot

Comment 2 2016-11-03 12:31:25 PDT

Attachment 293788 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:17: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:18: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 11 in 448 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 3 2016-11-05 23:06:47 PDT

Comment on attachment 293788 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=293788&action=review > Source/WebCore/ChangeLog:22 > + Remove unused DEBUG defines. DEBUG doesn’t seem 100% accurate here.

Joseph Pecoraro

Comment 4 2016-11-11 23:31:08 PST

Created attachment 294603 [details] [PATCH] For Bots

WebKit Commit Bot

Comment 5 2016-11-11 23:34:11 PST

Attachment 294603 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:17: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:18: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 11 in 444 files If any of these errors are false positives, please file a bug against check-webkit-style.

Joseph Pecoraro

Comment 6 2016-11-12 00:22:52 PST

Created attachment 294608 [details] [PATCH] For Landing Bots all look good. Lets try commit-queue!

WebKit Commit Bot

Comment 7 2016-11-12 01:00:34 PST

Comment on attachment 294608 [details] [PATCH] For Landing Clearing flags on attachment: 294608 Committed r208646: <http://trac.webkit.org/changeset/208646>

Note You need to log in before you can comment on or make changes to this bug.