| Summary: | Reduce PassRefPtr use in WebKit2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, buildbot, rniwa, ryanhaddad | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2016-11-02 23:55:39 PDT
Created attachment 293752 [details]
Patch
Created attachment 293768 [details]
Patch
Comment on attachment 293768 [details]
Patch
Make the bots green, plz.
This change appears to have caused these LayoutTests to fail: editing/selection/context-menu-on-text.html editing/spelling/context-menu-suggestions.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r208330%20(1201)/results.html Reverted r208330 for reason: This change appears to have caused two editing tests to fail on macOS. Committed r208342: <http://trac.webkit.org/changeset/208342> It looks like this change was also responsible for these LayoutTest crashes (which stopped occurring after the rollout): https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/16058 Comment on attachment 293768 [details] Patch Attachment 293768 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2456732 New failing tests: editing/mac/selection/context-menu-select-editability.html editing/selection/context-menu-text-selection-lookup.html editing/selection/button-right-click.html editing/selection/context-menu-text-selection.html fast/events/selectstart-prevent-selection-on-right-click.html editing/selection/context-menu-on-text.html editing/selection/minimal-user-select-crash.html media/controls-right-click-on-timebar.html editing/spelling/spellcheck-input-search-crash.html editing/spelling/context-menu-suggestions.html fast/events/contextmenu-scrolled-page-with-frame.html editing/selection/empty-cell-right-click.html fast/events/context-no-deselect.html Created attachment 293813 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
PassRefPtr usage does not exist anymore in Webkit GitHub as of today. So I am marking this as "RESOLVED WONTFIX". Thanks! |