Bug 164360

Summary:

Reduce PassRefPtr use in WebKit2

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ahmad.saleem792, buildbot, rniwa, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none

Alex Christensen

Reported 2016-11-02 23:55:39 PDT

Reduce PassRefPtr use in WebKit2

Attachments
Patch (28.31 KB, patch) 2016-11-02 23:56 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (29.34 KB, patch) 2016-11-03 09:24 PDT, Alex Christensen	thorton: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (2.50 MB, application/zip) 2016-11-03 15:53 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-11-02 23:56:22 PDT

Created attachment 293752 [details] Patch

Alex Christensen

Comment 2 2016-11-03 09:24:17 PDT

Created attachment 293768 [details] Patch

Tim Horton

Comment 3 2016-11-03 10:50:01 PDT

Comment on attachment 293768 [details] Patch Make the bots green, plz.

Alex Christensen

Comment 4 2016-11-03 10:50:47 PDT

http://trac.webkit.org/changeset/208330

Ryan Haddad

Comment 5 2016-11-03 13:53:24 PDT

This change appears to have caused these LayoutTests to fail: editing/selection/context-menu-on-text.html editing/spelling/context-menu-suggestions.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r208330%20(1201)/results.html

Ryan Haddad

Comment 6 2016-11-03 13:56:00 PDT

Reverted r208330 for reason: This change appears to have caused two editing tests to fail on macOS. Committed r208342: <http://trac.webkit.org/changeset/208342>

Ryan Haddad

Comment 7 2016-11-03 15:15:38 PDT

It looks like this change was also responsible for these LayoutTest crashes (which stopped occurring after the rollout): https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/builds/16058

Build Bot

Comment 8 2016-11-03 15:53:49 PDT

Comment on attachment 293768 [details] Patch Attachment 293768 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2456732 New failing tests: editing/mac/selection/context-menu-select-editability.html editing/selection/context-menu-text-selection-lookup.html editing/selection/button-right-click.html editing/selection/context-menu-text-selection.html fast/events/selectstart-prevent-selection-on-right-click.html editing/selection/context-menu-on-text.html editing/selection/minimal-user-select-crash.html media/controls-right-click-on-timebar.html editing/spelling/spellcheck-input-search-crash.html editing/spelling/context-menu-suggestions.html fast/events/contextmenu-scrolled-page-with-frame.html editing/selection/empty-cell-right-click.html fast/events/context-no-deselect.html

Build Bot

Comment 9 2016-11-03 15:53:52 PDT

Created attachment 293813 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Ahmad Saleem

Comment 10 2022-09-17 17:01:59 PDT

PassRefPtr usage does not exist anymore in Webkit GitHub as of today. So I am marking this as "RESOLVED WONTFIX". Thanks!

Note You need to log in before you can comment on or make changes to this bug.