Bug 164315

Summary: [GTK] Remove FileSystem::filenameToString() and use FileSystem::stringFromFileSystemRepresentation() everywhere instead
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2016-11-02 03:16:21 PDT
Both methods are the same, but FileSystem::filenameToString() is only defined by GTK and used everywhere. We should use the other one instead and remove FileSystem::filenameToString().
Attachments
Patch (17.53 KB, patch)
2016-11-02 03:17 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-11-02 03:17:48 PDT
Created attachment 293652 [details] Patch
WebKit Commit Bot
Comment 2 2016-11-02 03:19:42 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2016-11-02 05:37:05 PDT
Comment on attachment 293652 [details] Patch I guess this is fine. I suspect the purpose of using the different name was to indicate that GLib doesn't support filenames with embedded NUL characters, but whatever.
Carlos Garcia Campos
Comment 4 2016-11-02 06:05:33 PDT
Committed r208278: <http://trac.webkit.org/changeset/208278>
Note You need to log in before you can comment on or make changes to this bug.