Bug 164313 – Remove RenderMathMLOperator::shouldAllowStretching

• Component: MathML
• Status: RESOLVED FIXED

[Frédéric Wang (:fredw)]

This is a legacy function from the old MathML code. Now that we support large operator in displaystyle, the name is confusing since it is not just vertical/horizontal "stretchy" operators any more. I believe that now we can just expand it inside RenderMathMLOperator::updateMathOperator() by doing something like:

if (isStretchy())
    type = isVertical() ? MathOperator::Type::VerticalOperator : MathOperator::Type::HorizontalOperator;
else if (textContent() && isLargeOperatorInDisplayStyle())
    type = MathOperator::Type::DisplayOperator;
else  
    type = MathOperator::Type::NormalOperator;

and then the condition in RenderMathMLOperator::useMathOperator() will just become

m_mathOperator.type() != MathOperator::Type::NormalOperator || textContent() == minusSign

where we add the accessor MathOperator::type() { return m_operatorType; }

[Frédéric Wang (:fredw)]

Created attachment 294021 [details]
Patch

[Frédéric Wang (:fredw)]

Created attachment 294359 [details]
Patch

[Build Bot]

Comment on attachment 294359 [details]
Patch

Attachment 294359 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2489144

New failing tests:
compositing/absolute-inside-out-of-view-fixed.html

[Build Bot]

Created attachment 294367 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Frédéric Wang (:fredw)]

Created attachment 294407 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 294407 [details]
Patch

Clearing flags on attachment: 294407

Committed r208647: <http://trac.webkit.org/changeset/208647>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.