Bug 164298

Summary: LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html is flaky
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: MediaAssignee: Antoine Quint <graouts>
Severity: Normal CC: commit-queue, graouts
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 164784    
Description Flags
Patch none

Description Ryan Haddad 2016-11-01 15:50:06 PDT
LayoutTest media/modern-media-controls/placard-support/placard-support-airplay.html timing out

Comment 1 Ryan Haddad 2016-11-01 15:50:52 PDT
Test was landed again with http://trac.webkit.org/changeset/208242, seems to be timing out on release builds.
Comment 2 Ryan Haddad 2017-01-20 13:43:52 PST
The test fails or times out on every run:


--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-actual.txt
@@ -1,13 +1,8 @@
+FAIL: Timed out waiting for notifyDone to be called
 Testing the PlacardSupport behavior when playing media through AirPlay.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-got event false
-got event true
-PASS mediaController.controls.showsPlacard is true
-PASS mediaController.controls.children.includes(mediaController.controls.airplayPlacard) is true
-PASS successfullyParsed is true
Comment 3 Ryan Haddad 2017-01-20 13:44:25 PST
Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/210979
Comment 4 Antoine Quint 2017-01-24 13:06:34 PST
Created attachment 299621 [details]
Comment 5 Jon Lee 2017-01-24 13:15:18 PST
Comment on attachment 299621 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=299621&action=review

> LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay.html:41
> +    window.internals.setMockMediaPlaybackTargetPickerState('Sleepy TV', 'DeviceAvailable');

If there are more of these. I think we should refactor all of this setup out to a helper script.
Comment 6 WebKit Commit Bot 2017-01-24 19:01:16 PST
Comment on attachment 299621 [details]

Clearing flags on attachment: 299621

Committed r211132: <http://trac.webkit.org/changeset/211132>
Comment 7 WebKit Commit Bot 2017-01-24 19:01:20 PST
All reviewed patches have been landed.  Closing bug.