Bug 164283

Summary:

Web Inspector: Use more references in inspector code

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, cdumez, commit-queue, dbates, esprehn+autocc, glenn, japhet, joepeck, kondapallykalyan, mattbaker, mkwst, nvasilyev, simon.fraser, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2016-11-01 12:16:06 PDT

Summary: Use more references in inspector code There are plenty of InspectorInstrumentation methods which take a pointer but do not need to. While going through the list we can make the instrumentation methods more consistent in some ways.

Attachments
[PATCH] Proposed Fix (77.84 KB, patch) 2016-11-01 12:18 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (77.78 KB, patch) 2016-11-01 12:20 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-11-01 12:18:36 PDT

Created attachment 293566 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 2 2016-11-01 12:20:04 PDT

Created attachment 293567 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 3 2016-11-01 14:45:49 PDT

Comment on attachment 293567 [details] [PATCH] Proposed Fix Clearing flags on attachment: 293567 Committed r208240: <http://trac.webkit.org/changeset/208240>

WebKit Commit Bot

Comment 4 2016-11-01 14:45:54 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 5 2016-11-01 15:07:37 PDT

Attempted a build fix: <https://trac.webkit.org/changeset/208250>

Note You need to log in before you can comment on or make changes to this bug.