Bug 164273

Summary: [Win] Copy build results to AAS 'Program Files' folder.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, keith_miller, lforschler, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2016-11-01 08:01:02 PDT
The preferred location for the binaries is the AAS 'Program Files' folder.
Comment 1 Per Arne Vollan 2016-11-01 08:17:59 PDT
Created attachment 293553 [details]
Patch
Comment 2 Per Arne Vollan 2016-11-01 08:23:25 PDT
<rdar://problem/28878624>
Comment 3 Brent Fulgham 2016-11-01 10:30:30 PDT
Comment on attachment 293553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293553&action=review

> Source/WTF/WTF.vcxproj/WTF.proj:75
> +    <CreateItem Include="$(ConfigurationBuildDir)\build32\bin32\WTF$(DebugSuffix).pdb">

I'm worried this change prevents us from copying other "pdb" files that might be generated during the build. Are you sure we only need the one file?

> Source/WTF/WTF.vcxproj/WTF.proj:78
> +    <CreateItem Include="$(ConfigurationBuildDir)\build64\bin64\WTF$(DebugSuffix).pdb">

Ditto.
Comment 4 Per Arne Vollan 2016-11-01 11:39:34 PDT
(In reply to comment #3)
> Comment on attachment 293553 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293553&action=review
> 
> > Source/WTF/WTF.vcxproj/WTF.proj:75
> > +    <CreateItem Include="$(ConfigurationBuildDir)\build32\bin32\WTF$(DebugSuffix).pdb">
> 
> I'm worried this change prevents us from copying other "pdb" files that
> might be generated during the build. Are you sure we only need the one file?
> 
> > Source/WTF/WTF.vcxproj/WTF.proj:78
> > +    <CreateItem Include="$(ConfigurationBuildDir)\build64\bin64\WTF$(DebugSuffix).pdb">
> 
> Ditto.

The WTF project only generates WTF.dll, so I believe we only need the one file. The same goes for the WebKit project. The JavaScriptCore project generates some executables (testapi.exe, etc.) in addition to JavaScriptCore.dll, but this patch only copies JavaScriptCore.dll to the build result folder, so only JavaScriptCore.pdb should be needed. It is my understanding that we don't need to include these extra JSC executables, please correct me if I am wrong.

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2016-11-02 04:02:45 PDT
Comment on attachment 293553 [details]
Patch

Clearing flags on attachment: 293553

Committed r208275: <http://trac.webkit.org/changeset/208275>
Comment 6 WebKit Commit Bot 2016-11-02 04:02:50 PDT
All reviewed patches have been landed.  Closing bug.