| Summary: | [Modern Media Controls] load all media controller scripts and styles automatically | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, eric.carlson, graouts, joepeck | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2016-11-01 07:11:56 PDT
Created attachment 293551 [details]
Patch
Comment on attachment 293551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293551&action=review > LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:11 > + request.open("GET", `${modulePath}/js-files`, false); Does this file exist yet? Comment on attachment 293551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293551&action=review >> LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:11 >> + request.open("GET", `${modulePath}/js-files`, false); > > Does this file exist yet? It looks like it does! > LayoutTests/media/modern-media-controls/resources/media-controls-loader.js:15 > + document.write(`<script type="text/javascript" src="${modulePath}/${jsFile}"></script>`); Nit: All of the `type="text/javascript"` attributes are unnecessary and could be removed. But at least you are consistent and use them everywhere. Comment on attachment 293551 [details] Patch Clearing flags on attachment: 293551 Committed r208226: <http://trac.webkit.org/changeset/208226> All reviewed patches have been landed. Closing bug. |