Bug 164244

Summary: CSS.supports("font-variation-settings", "'wght' 500") erroneously returns false
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lorp, mmaxfield
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mcatanzaro: review+, buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch for committing none

Myles C. Maxfield
Reported 2016-10-31 15:32:39 PDT
This is because the "if (m_context.variationFontsEnabled)" is false in the CSSPropertyFontVariationSettings block of CSSParser::parseValue().
Attachments
Patch (6.41 KB, patch)
2016-10-31 17:53 PDT, Myles C. Maxfield 		mcatanzaro: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (10.92 MB, application/zip)
2016-10-31 19:22 PDT, Build Bot 		no flags
Details
Patch for committing (8.10 KB, patch)
2016-11-02 19:53 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-10-31 15:40:56 PDT
The other CSSParserContext() constructor is being called (implicitly because of the CSSParserMode in DOMCSSNamespace::supports())
Myles C. Maxfield
Comment 2 2016-10-31 16:08:54 PDT
This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=164251 *** This bug has been marked as a duplicate of bug 164251 ***
Myles C. Maxfield
Comment 3 2016-10-31 16:14:18 PDT
....which isn't going to happen. Back to "reopened"
Myles C. Maxfield
Comment 4 2016-10-31 17:53:51 PDT
Created attachment 293505 [details] Patch
Build Bot
Comment 5 2016-10-31 19:22:44 PDT
Comment on attachment 293505 [details] Patch Attachment 293505 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2418091 New failing tests: fast/text/variations/css-supports-runtime-switch.html
Build Bot
Comment 6 2016-10-31 19:22:47 PDT
Created attachment 293516 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Myles C. Maxfield
Comment 7 2016-11-02 19:53:04 PDT
Created attachment 293737 [details] Patch for committing
WebKit Commit Bot
Comment 8 2016-11-02 20:28:26 PDT
Comment on attachment 293737 [details] Patch for committing Clearing flags on attachment: 293737 Committed r208321: <http://trac.webkit.org/changeset/208321>
Note You need to log in before you can comment on or make changes to this bug.