Bug 164242

Summary: Enable custom elements by default everywhere
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, koivisto, mcatanzaro, webkit
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Patch
none
Patch
none
Enable it in CMake builds none

Description Ryosuke Niwa 2016-10-31 14:57:21 PDT 
The feature is done. Enable it everywhere.
Comment 1 Ryosuke Niwa 2016-10-31 15:00:48 PDT 
Created attachment 293471 [details]
Patch
Comment 2 Ryosuke Niwa 2016-10-31 15:03:44 PDT 
Created attachment 293474 [details]
Patch
Comment 3 Antti Koivisto 2016-10-31 17:07:10 PDT 
Comment on attachment 293474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293474&action=review

> Source/WebCore/features.json:558
> -            "status": "In Development"
> +            "status": "Done"

Nice!
Comment 4 WebKit Commit Bot 2016-10-31 17:35:04 PDT 
Comment on attachment 293474 [details]
Patch

Clearing flags on attachment: 293474

Committed r208201: <http://trac.webkit.org/changeset/208201>
Comment 5 WebKit Commit Bot 2016-10-31 17:35:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2016-10-31 18:04:32 PDT 
Note that it's still OFF for all CMake ports since you didn't change WebKitFeatures.cmake. Remember that WebKitFeatures.cmake only affects developers, not end users, at least for CMake ports.
Comment 7 Michael Catanzaro 2016-10-31 18:05:01 PDT 
(In reply to comment #6)
> Remember that WebKitFeatures.cmake only affects
> developers, not end users, at least for CMake ports.

I meant FeatureList.pm here. :)
Comment 8 Ryosuke Niwa 2016-10-31 19:49:21 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > Remember that WebKitFeatures.cmake only affects
> > developers, not end users, at least for CMake ports.
> 
> I meant FeatureList.pm here. :)

Oh oops, we need to fix that.
Comment 9 Ryosuke Niwa 2016-10-31 19:51:38 PDT 
Apparently, I didn't fix cmake builds.
Comment 10 Ryosuke Niwa 2016-10-31 19:53:27 PDT 
Created attachment 293518 [details]
Enable it in CMake builds
Comment 11 Ryosuke Niwa 2016-10-31 23:50:54 PDT 
Comment on attachment 293518 [details]
Enable it in CMake builds

Clearing flags on attachment: 293518

Committed r208217: <http://trac.webkit.org/changeset/208217>
Comment 12 Ryosuke Niwa 2016-10-31 23:51:00 PDT 
All reviewed patches have been landed.  Closing bug.