Bug 164227
| Summary: | Debug JSC test microbenchmarks/pure-get-by-id-cse-2.js timing out | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, saam |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=163305 | ||
Ryan Haddad
** The following JSC stress test failures have been introduced:
microbenchmarks/pure-get-by-id-cse-2.js.dfg-eager
microbenchmarks/pure-get-by-id-cse-2.js.dfg-eager-no-cjit-validate
microbenchmarks/pure-get-by-id-cse-2.js.dfg-maximal-flush-validate-no-cjit
microbenchmarks/pure-get-by-id-cse-2.js.no-cjit-validate-phases
microbenchmarks/pure-get-by-id-cse-2.js.no-ftl
microbenchmarks/pure-get-by-id-cse-2.js.no-llint
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/4409
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
Will fix now.
Saam Barati
landed fix in:
https://trac.webkit.org/changeset/208160
Chris Dumez
Reverted r208117 and r208160 for reason:
Regressed Speedometer by >1.5%
Committed r208588: <http://trac.webkit.org/changeset/208588>
Alexey Proskuryakov
Looks like both revisions got reverted, so this must fixed for good. Is that correct?
Saam Barati
(In reply to comment #4)
> Looks like both revisions got reverted, so this must fixed for good. Is that
> correct?
Yeah sounds correct to me. I'm going to try to re-land the patch at some point soon, so I'll make sure to make this test run for less time when I do.