Summary: | Use #pragma once in WebCore | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | WebCore Misc. | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, joepeck | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-10-29 16:47:04 PDT
Created attachment 293318 [details]
[PATCH] Proposed Fix
Need to make sure the bots are green.
Comment on attachment 293318 [details]
[PATCH] Proposed Fix
rs=me
Created attachment 293433 [details]
[PATCH] For Bots
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTML.mm:41:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLInputElement.h:28:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLTextFormControlElement.h:27:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLFormControlElementWithState.h:26:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/HTMLFormControlElement.h:31:
> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/Autocapitalize.h:28:
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebCore.framework/PrivateHeaders/WebAutocapitalize.h:34:3: error: typedef redefinition with different types ('enum WebAutocapitalizeType' vs 'enum WebAutocapitalizeType')
> } WebAutocapitalizeType;
> ^
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTML.mm:36:
> In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMPrivate.h:30:
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/WebKitLegacy.framework/PrivateHeaders/WebAutocapitalize.h:34:3: note: previous definition is here
> } WebAutocapitalizeType;
> ^
> 6 errors generated.
Apparently WebAutocapitalize is SPI.
I'll not #pragma once it.
Created attachment 293439 [details]
[PATCH] For Bots
Comment on attachment 293439 [details] [PATCH] For Bots Clearing flags on attachment: 293439 Committed r208179: <http://trac.webkit.org/changeset/208179> |