Bug 164174

Summary: Remove some unnecessary includes
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
mcatanzaro: review-, joepeck: commit-queue-
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-10-28 22:06:26 PDT
Remove some unnecessary includes
Attachments
[PATCH] Proposed Fix (55.92 KB, patch)
2016-10-28 22:07 PDT, Joseph Pecoraro 		mcatanzaro: review-
joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (55.42 KB, patch)
2016-10-29 10:53 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-10-28 22:07:08 PDT
Created attachment 293275 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2016-10-28 22:09:21 PDT
Attachment 293275 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ComposedTreeAncestorIterator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 3 2016-10-29 08:45:26 PDT
Comment on attachment 293275 [details] [PATCH] Proposed Fix Always a worthwhile task, but looks like it broke iOS and EFL.
Joseph Pecoraro
Comment 4 2016-10-29 10:53:44 PDT
Created attachment 293298 [details] [PATCH] Proposed Fix Lets give the bots a try here.
WebKit Commit Bot
Comment 5 2016-10-29 10:55:19 PDT
Attachment 293298 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ComposedTreeAncestorIterator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 6 2016-10-29 11:38:54 PDT
Comment on attachment 293298 [details] [PATCH] Proposed Fix Builds!
Darin Adler
Comment 7 2016-10-29 13:52:39 PDT
Sure would be neat to have a bot that just tries this year round. Keeps trying to remove includes and forward declarations and we only see patches once the bot gets it compiling on all platforms.
WebKit Commit Bot
Comment 8 2016-10-29 14:15:47 PDT
Comment on attachment 293298 [details] [PATCH] Proposed Fix Clearing flags on attachment: 293298 Committed r208112: <http://trac.webkit.org/changeset/208112>
WebKit Commit Bot
Comment 9 2016-10-29 14:15:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.