| Summary: | Remove some unnecessary includes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | WebKit Misc. | Assignee: | Joseph Pecoraro <joepeck> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Joseph Pecoraro
2016-10-28 22:06:26 PDT
Created attachment 293275 [details]
[PATCH] Proposed Fix
Attachment 293275 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/ComposedTreeAncestorIterator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293275 [details]
[PATCH] Proposed Fix
Always a worthwhile task, but looks like it broke iOS and EFL.
Created attachment 293298 [details]
[PATCH] Proposed Fix
Lets give the bots a try here.
Attachment 293298 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/ComposedTreeAncestorIterator.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 293298 [details]
[PATCH] Proposed Fix
Builds!
Sure would be neat to have a bot that just tries this year round. Keeps trying to remove includes and forward declarations and we only see patches once the bot gets it compiling on all platforms. Comment on attachment 293298 [details] [PATCH] Proposed Fix Clearing flags on attachment: 293298 Committed r208112: <http://trac.webkit.org/changeset/208112> All reviewed patches have been landed. Closing bug. |