Bug 164152

Summary: autogenerated files from wasm.json should be in derived sources.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Keith Miller
Reported 2016-10-28 14:24:08 PDT
Right now we manually make these files. We should make this part of the DerivedSources.make script. This won't be sustainable long term.
Attachments
Patch (72.49 KB, patch)
2016-10-31 00:17 PDT, Keith Miller 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-10-31 00:17:00 PDT
Created attachment 293397 [details] Patch
WebKit Commit Bot
Comment 2 2016-10-31 00:19:44 PDT
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Keith Miller
Comment 3 2016-10-31 09:27:57 PDT
Committed r208148: <http://trac.webkit.org/changeset/208148>
Note You need to log in before you can comment on or make changes to this bug.