Bug 164152 - autogenerated files from wasm.json should be in derived sources.
Summary: autogenerated files from wasm.json should be in derived sources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-28 14:24 PDT by Keith Miller
Modified: 2016-10-31 09:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (72.49 KB, patch)
2016-10-31 00:17 PDT, Keith Miller
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-10-28 14:24:08 PDT
Right now we manually make these files. We should make this part of the DerivedSources.make script. This won't be sustainable long term.
Comment 1 Keith Miller 2016-10-31 00:17:00 PDT
Created attachment 293397 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-31 00:19:44 PDT
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Keith Miller 2016-10-31 09:27:57 PDT
Committed r208148: <http://trac.webkit.org/changeset/208148>