Bug 164121

Summary: [CMake] Changing enabled features should trigger recompiling all IDL
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: BindingsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, gyuyoung.kim, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2016-10-28 04:27:44 PDT 
Changing enabled features should trigger recompiling all IDL
because some of them use #if.

generate-bindings-all.pl was introduced in
<http://trac.webkit.org/changeset/207617>.  Before this change,
updating supplemental_dependency.tmp triggered regenerating all
bindings. Changing enabled features usually involves adding or
removing IDL files. As the result, all IDL would be recompiled.
But, after the change, updating supplemental_dependency.tmp does
trigger regenerating all bindings. So, we need to explicitly
trigger recompiling all IDL by changing enabled features.
Comment 1 Fujii Hironori 2016-10-28 04:41:04 PDT 
Created attachment 293143 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-28 05:27:27 PDT 
Comment on attachment 293143 [details]
Patch

Clearing flags on attachment: 293143

Committed r208044: <http://trac.webkit.org/changeset/208044>
Comment 3 WebKit Commit Bot 2016-10-28 05:27:31 PDT 
All reviewed patches have been landed.  Closing bug.