Bug 164101

Summary:

Update ANGLE

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, jeremyhu

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
patch	darin: review+

Alex Christensen

Reported 2016-10-27 18:13:27 PDT

Update ANGLE

Attachments
Patch (11.00 MB, patch) 2016-10-27 18:28 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (10.48 MB, patch) 2016-10-27 18:59 PDT, Alex Christensen	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-10-27 18:28:30 PDT

Created attachment 293093 [details] Patch

Alex Christensen

Comment 2 2016-10-27 18:59:31 PDT

Created attachment 293099 [details] patch

WebKit Commit Bot

Comment 3 2016-10-27 19:15:00 PDT

Attachment 293099 [details] did not pass style-queue: ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvedepthstencil11_ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvedepth11_ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvedepthstencil11_vs.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbapremultiply2d11ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/resolvestencil11_ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbpremultiply2d11ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbaunmultiply2d11ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. ERROR: Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/shaders/compiled/passthroughrgbunmultiply2d11ps.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] ERROR: Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 764 in 919 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 4 2016-10-27 20:33:04 PDT

Comment on attachment 293099 [details] patch rs=me

Alex Christensen

Comment 5 2016-10-27 23:04:02 PDT

https://trac.webkit.org/r208036

Alex Christensen

Comment 6 2016-10-27 23:05:05 PDT

I also replaced some tabs with spaces in these files: src/tests/compiler_tests/QualificationOrder_test.cpp src/tests/third_party/rapidjson/include/rapidjson/prettywriter.h src/tests/third_party/rapidjson/include/rapidjson/reader.h src/tests/third_party/rapidjson/include/rapidjson/writer.h src/third_party/murmurhash/MurmurHash3.h

Jeremy Huddleston Sequoia

Comment 7 2016-11-29 01:42:21 PST

Caused: https://bugs.webkit.org/show_bug.cgi?id=165135

Note You need to log in before you can comment on or make changes to this bug.