Bug 164099

Summary: One file per class for Executable.h/.cpp
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Geoffrey Garen
Reported 2016-10-27 17:28:01 PDT
One file per class for Executable.h/.cpp
Attachments
Patch (1.10 MB, patch)
2016-10-27 17:30 PDT, Geoffrey Garen 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-10-27 17:30:42 PDT
Created attachment 293087 [details] Patch
Geoffrey Garen
Comment 2 2016-10-27 17:31:14 PDT
This is a first step toward fixing some problems with code caching.
Saam Barati
Comment 3 2016-10-28 01:27:49 PDT
Comment on attachment 293087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293087&action=review r=me I wish bugzilla did a better job with showing diffs for these patches. > PerformanceTests/ChangeLog:1 > +2016-10-27 Geoffrey Garen <ggaren@apple.com> Is this change expected?
Geoffrey Garen
Comment 4 2016-10-28 12:24:23 PDT
> > PerformanceTests/ChangeLog:1 > > +2016-10-27 Geoffrey Garen <ggaren@apple.com> > > Is this change expected? Oops! Fixed.
Geoffrey Garen
Comment 5 2016-10-28 13:07:48 PDT
Committed r208063: <http://trac.webkit.org/changeset/208063>
Csaba Osztrogonác
Comment 6 2016-10-28 14:01:55 PDT
(In reply to comment #5) > Committed r208063: <http://trac.webkit.org/changeset/208063> It broke the CLoop build, see build.webkit.org for details.
Note You need to log in before you can comment on or make changes to this bug.