Bug 164080 – REGRESSION: http/tests/websocket/tests/hybi/closed-when-entering-page-cache.html and http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html are flaky

• Component: New Bugs
• Status: RESOLVED CONFIGURATION CHANGED

[Ryan Haddad]

http/tests/websocket/tests/hybi/closed-when-entering-page-cache.html and http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html are flaky

https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r207990%20(19318)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fclosed-when-entering-page-cache.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fstop-on-resume-in-error-handler.html

--- /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/websocket/tests/hybi/closed-when-entering-page-cache-expected.txt
+++ /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/websocket/tests/hybi/closed-when-entering-page-cache-actual.txt
@@ -1,21 +1 @@
-CONSOLE MESSAGE: WebSocket connection to 'ws://127.0.0.1:8880/websocket/tests/hybi/echo' failed: WebSocket is closed due to suspension.
-Test that an open WebSocket does not prevent a page from entering page cache.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-pageshow - not from cache
-pagehide - entering cache
-pageshow - from cache
-PASS Page did enter and was restored from the page cache
-PASS error event fired
-PASS wasRestoredFromPageCache is true
-PASS close event fired
-PASS wasRestoredFromPageCache is true
-PASS receivedErrorEvent is true
-PASS closeEvent.wasClean is false
-PASS closeEvent.code is 1006
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+This page should go back. If a test outputs the contents of this page, then the test page failed to enter the page cache.

[Ryan Haddad]

Earliest failure on dashboard was in this range:
https://trac.webkit.org/log/?verbose=on&rev=207967&stop_rev=207953

[Ryan Haddad]

Marked tests as flaky in http://trac.webkit.org/projects/webkit/changeset/208187. Youenn, could you take a look at this?

[Radar WebKit Bug Importer]

<rdar://problem/29035055>

[Ryan Haddad]

These tests are no longer flaky. This may have been fixed with the rollout of r207967 in https://trac.webkit.org/changeset/208200