Bug 164073

Summary:

Web Inspector: Worker should recover if Inspector is closed and never sent Worker.initialized command

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

163844

Bug Blocks:

Attachments:

Description	Flags
[PATCH] Proposed Fix	bburg: review+

Description Joseph Pecoraro 2016-10-27 13:30:59 PDT

Summary:
Worker should recover if Inspector is closed and never sent Worker.initialized command

In the unlikely event that the Inspector crashes and disconnects from a Worker during initialization it could leave the Worker paused waiting for debugger messages. When we disconnect from a worker we should terminate the debugger message only run loop mode.

Comment 1 Joseph Pecoraro 2016-10-27 13:33:56 PDT

Created attachment 293050 [details]
[PATCH] Proposed Fix

Comment 2 BJ Burg 2016-10-27 13:36:49 PDT

Comment on attachment 293050 [details]
[PATCH] Proposed Fix

Very nice, r=me

Comment 3 Joseph Pecoraro 2016-10-27 15:23:53 PDT

<https://trac.webkit.org/changeset/208011>